Add Multisig Batch utility for forge scripts #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ith-harvey
changed the title
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
ith-harvey
changed the title
Oighty
reviewed
Nov 16, 2025
Contributor
Oighty
left a comment
Oighty
left a comment
There was a problem hiding this comment.
I think this is fine as an interim solution. I talked to Iryna about bumping the version to fix some of the API routes that have been deprecated on certain deployments of the Safe Transaction Service, but it may take more work with the import errors you mentioned. The safe-utils library also doesn't support all the chains. We may eventually want to find another solution or fork it and implement fixes ourselves.
Oighty
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR relocates MultiSigBatchBase.sol from m-portal-lite into the common package so it can be shared across repositories. Since multisig batch operations will be used across multiple projects for upgrades and related scripting tasks, centralizing this contract in common avoids duplication and ensures consistent behavior.
Motivation
MultiSigBatchBase.sol exists only in m-portal-lite, but upcoming workflows require multisig batch operations in several repos. Moving this contract into common allows all repositories to import the same implementation directly, rather than maintaining multiple copies.
Changes
• Added MultiSigBatchBase.sol to the common package
• Updated foundry.toml to ignore safe-utils lint warnings
• Imported the same version of safe-utils used in m-portal-lite (latest version introduced breaking import errors, so this PR uses the compatible release)
Next steps
remove
MultisigBatchBase.solm-portal-lite to reference the one now incommon